Skip to content

Commit 252796f

Browse files
committed
review feedback
1 parent dafe3cb commit 252796f

File tree

1 file changed

+3
-4
lines changed
  • lib/inferno/entities

1 file changed

+3
-4
lines changed

lib/inferno/entities/ig.rb

+3-4
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class IG < Entity
2323

2424
include Inferno::Entities::Attributes
2525

26-
def initialize(params)
26+
def initialize(**params)
2727
super(params, ATTRIBUTES)
2828

2929
@profiles = []
@@ -57,7 +57,7 @@ def self.from_tgz(ig_path)
5757
Zlib::GzipReader.open(ig_path)
5858
)
5959

60-
ig = IG.new({})
60+
ig = IG.new
6161

6262
tar.each do |entry|
6363
next if skip_item?(entry.full_name, entry.directory?)
@@ -75,7 +75,7 @@ def self.from_tgz(ig_path)
7575
end
7676

7777
def self.from_directory(ig_directory)
78-
ig = IG.new({})
78+
ig = IG.new
7979

8080
ig_path = Pathname.new(ig_directory)
8181
Dir.glob("#{ig_path}/**/*") do |f|
@@ -102,7 +102,6 @@ def self.skip_item?(relative_path, is_directory)
102102

103103
file_name = relative_path.split('/').last
104104

105-
# TODO: consider making these regexes we can iterate over in a single loop
106105
return true unless file_name.end_with? '.json'
107106
return true unless relative_path.start_with? 'package/'
108107

0 commit comments

Comments
 (0)