Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Hacl_Hash_SHA2 does not appear as a library to link to #312

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ntamas
Copy link
Contributor

@ntamas ntamas commented Sep 1, 2024

When trying to update PyOxidizer and PyOxy to support standalone builds of Python 3.12, I noticed that the build attempted to link to a library named Hacl_Hash_SHA2 when pyoxy was linked (with -lHacl_Hash_SHA2). This PR fixes the metadata in PYTHON.json.

Copy link
Collaborator

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me if the builds pass.

@zanieb
Copy link
Collaborator

zanieb commented Sep 6, 2024

Can you share a diff of the PYTHON.json metadata?

@ntamas
Copy link
Contributor Author

ntamas commented Sep 6, 2024

Sure! I'm attaching two diffs here; full.diff was generated with diff -u, but it contains lots of lines where the only difference is in the names of the temporary folders where the build was executed. relevant.diff was created manually from full.diff by deleting those chunks where the only difference was the name of the temporary folder so you can see the differences more clearly.

Both diffs are attached in a ZIP file here: diffs.zip

@zanieb zanieb self-assigned this Sep 7, 2024
@zanieb
Copy link
Collaborator

zanieb commented Sep 9, 2024

Thanks! The change in the metadata makes sense to me but I don't fully understand why it was written this way in the first place?

@ntamas
Copy link
Contributor Author

ntamas commented Sep 9, 2024

I don't know either -- maybe @indygreg remembers? I think he was the one who initially wrote the code for supporting Python 3.12 where the pre-3.12 hash functions were replaced with implementations from HACL*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants