Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Install fails on SmartOS: Ninja prebuild step does not detect platform #91

Closed
doublerebel opened this issue Oct 2, 2016 · 1 comment

Comments

@doublerebel
Copy link
Contributor

doublerebel commented Oct 2, 2016

Hello,

This latest release using ninja/gyp.js/ninja.js fails to build on SmartOS. none of the solaris-specific flags end up in the .ninja files. I was able to manually change and add the correct cflags, ldflags, and defines, to the .ninja files for bud and libuv and build. I had to add libuv's unix/sunos.c to the .ninja file for libuv also. (I pulled all the necessary information from the .gyp files.)

This is my first time building bud since the build system changed.

I'm not sure exactly where the bug is, but I think this relates to indutny/gyp.js#1. I tried several ways to trace it but this is a very new build system for me! ninja-build is available from pkgsrc for SmartOS and seems to have no issues.

@indutny
Copy link
Owner

indutny commented Nov 4, 2016

Should be fixed with gyp.js@1.4.14 . Please give it a try!

Sorry for delay!

@indutny indutny closed this as completed Nov 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants