Skip to content
This repository was archived by the owner on Aug 16, 2023. It is now read-only.

Add pre-commit linting hooks #54

Closed
redgardner opened this issue Oct 30, 2020 · 3 comments · Fixed by #55
Closed

Add pre-commit linting hooks #54

redgardner opened this issue Oct 30, 2020 · 3 comments · Fixed by #55

Comments

@redgardner
Copy link

In order to catch issues earlier rather than later, pre-commit linting hooks using husky should be set up. Discussed on PR #51

@redgardner
Copy link
Author

I went ahead and put a PR together for this. Hope that's okay.

@kevindigo kevindigo linked a pull request Oct 30, 2020 that will close this issue
@kevindigo
Copy link
Collaborator

@redgardner : It's absolutely OK that you jumped into this. I added the hacktoberfest label to this issue, and linked this issue to the PR. Hopefully that will be enough for you to get credit. (I still find all these combinations of labels to be a bit confusing.)

@redgardner
Copy link
Author

Thanks! I do see this showing up as pending in my dashboard. So should be all good. I appreciate it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants