Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using latest version of watersurfaces: version 'watersurfaces_2024' #190

Open
4 tasks done
florisvdh opened this issue Nov 26, 2024 · 3 comments
Open
4 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@florisvdh
Copy link
Member

florisvdh commented Nov 26, 2024

A new version of watersurfaces is available - https://doi.org/10.5281/zenodo.14203168.

To do:

  • update read_watersurfaces()
  • n2khab-preprocessing repo: generate a new version of watersurfaces_hab
  • update read_watersurfaces_hab()
  • release watersurfaces_hab at Zenodo and release new package version
@florisvdh florisvdh added the enhancement New feature or request label Nov 26, 2024
@florisvdh florisvdh changed the title Follow up the latest version of watersurfaces: version 'watersurfaces_2024' Error using latest version of watersurfaces: version 'watersurfaces_2024' Nov 27, 2024
@florisvdh
Copy link
Member Author

@jeroenvdborre discovered that read_watersurfaces() currently errors with the latest version of watersurfaces. This is within expectations, as we didn't yet update the function to the latest data source version:

n2khab/R/read_habitatdata.R

Lines 581 to 587 in 74bce51

read_watersurfaces <-
function(file = NULL,
extended = FALSE,
fix_geom = FALSE,
version = c("watersurfaces_v1.2",
"watersurfaces_v1.1",
"watersurfaces_v1.0")) {

Pull requests are welcome!

@cecileherr cecileherr self-assigned this Dec 6, 2024
@florisvdh
Copy link
Member Author

@cecileherr you may find this notebook useful too; from inbo/n2khab-preprocessing#71 (comment).

@cecileherr
Copy link
Collaborator

see PR #192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants