Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URI handling: gun and cowlib handle iodata, but shotgun only handles string #104

Closed
kennethlakin opened this issue Oct 17, 2015 · 2 comments

Comments

@kennethlakin
Copy link
Contributor

As mentioned in the title, gun and cowlib handle iodata URIs, but shotgun does not. Making the change to shotgun required to handle iodata URIs seems to be a safe and compatible thing to do.

cowlib has handled iodata URIs for more than a year ninenines/cowlib@aca97c9#diff-eb68da7989f0e64a350f8ea8707c5b41R283 and the gun manual has mentioned gun's support for iodata URIs for nearly seven months: ninenines/gun@4ae8967#diff-28defa69a935b240f7ac34be244eeb05R165 .

The change will not affect the performance of current shotgun clients that pass in a URI with a leading "/"; a second clause is being added to check_uri to handle iodata and lists whose first element is not "/": kennethlakin@ab6e841#diff-061a9243c5d9756e7d8111fd8f4b4ba7L641

@kennethlakin
Copy link
Contributor Author

I rebased the branch against master, so I updated my initial comment to point to the new commit and line. The content remains the same.

@kennethlakin
Copy link
Contributor Author

Merged into master. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants