Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oauth2 Client_secret on frontend is always a security issue #179

Open
kadary opened this issue Jan 28, 2019 · 3 comments
Open

Oauth2 Client_secret on frontend is always a security issue #179

kadary opened this issue Jan 28, 2019 · 3 comments

Comments

@kadary
Copy link

kadary commented Jan 28, 2019

Hello,

You asked to fill an issue if we think the Oauth2 app *client_secret is security risk in frontend.

Just to let you know that your client secret can be use to manipulate other GitHub resources using other mechanism than Oauth2 authorization_code flow.
They can be use in GitHub authorization APIs to gain informations about your end-user for example (https://developer.github.com/v3/oauth_authorizations/).

@szabolcs-szilagyi
Copy link

Hello @kadary,

I've been thinking about the same when reading about client_secret to be used on the front-end. After reading your ticket about it the thing that made it even more funnier that we even think alike with our profile pictures. 😆

@GerkinDev
Copy link

GerkinDev commented Feb 1, 2021

Well, when I saw this, I jumped out from my seat. I expected some kind of hashing or something to hide it.

So, I've moved to https://utteranc.es/, which does not have this security issue.

@sariabiha
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@szabolcs-szilagyi @kadary @GerkinDev @sariabiha and others