Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data when uninstalling GiveWP #7670

Open
richtabor opened this issue Jan 9, 2025 · 2 comments
Open

Remove data when uninstalling GiveWP #7670

richtabor opened this issue Jan 9, 2025 · 2 comments
Assignees
Labels
keep-fresh "Keep Fresh" issues should not be marked as stale. type: bug Existing functionality is broken

Comments

@richtabor
Copy link

User Story

As a user, I want to not have legacy GiveWP data laying around so that my site is less cluttered with data I'm no longer using.

Details

Ensure that all GiveWP data, including custom database tables and settings are removed when the plugin is uninstalled. This aligns with user expectations and best practices for plugins that offer a complete uninstall process.

Expected Behavior

All GiveWP data, including custom tables, settings, and files, is completely removed when the plugin is uninstalled.

If retaining data is beneficial (e.g., for backups or future reinstallation), plugins often include an option to keep data during uninstallation, leaving the choice up to the user.

Steps to Reproduce

  1. Install and activate the GiveWP plugin.
  2. Configure plugin settings and create test data.
  3. Deactivate and uninstall the plugin.
  4. Check the database and file system for residual GiveWP data.
  5. See user roles for a UI-facing example of residual data.

Visuals

GiveWP is no longer installed on this site:

CleanShot 2025-01-08 at 21 09 05

Additional Context

Was testing out GiveWP and ran into this after I finished.

@richtabor richtabor added the type: bug Existing functionality is broken label Jan 9, 2025
@jonwaldstein jonwaldstein self-assigned this Jan 9, 2025
@jonwaldstein
Copy link
Contributor

@richtabor thanks for adding this, we put it into our backlog - however feel free to open a pull request 😄

Copy link

This issue is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 14 additional days. Note, if this Issue is reporting a bug, please reach out to our support at https://givewp.com/support. If this is a feature request, please see our feedback board at feedback.givewp.com — that’s the best place to make feature requests, unless you’re providing a PR.

@github-actions github-actions bot added the Stale label Feb 24, 2025
@JasonTheAdams JasonTheAdams added keep-fresh "Keep Fresh" issues should not be marked as stale. and removed Stale labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-fresh "Keep Fresh" issues should not be marked as stale. type: bug Existing functionality is broken
Projects
None yet
Development

No branches or pull requests

3 participants