Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server side validation errors don't reopen modal or slide down panel #264

Closed
DevinWalker opened this issue Sep 17, 2015 · 8 comments
Closed
Assignees
Milestone

Comments

@DevinWalker
Copy link
Member

Scenario: If a user attempts to donate using a Give form in modal view and there is an error returned back from the payment gateway

Problem: The user has no idea the error occurred without clicking back into the modal

9-16-2015 5-53-48 pm
9-16-2015 5-53-42 pm

@DevinWalker DevinWalker added this to the 1.3 Milestone milestone Sep 17, 2015
@pryley
Copy link
Contributor

pryley commented Sep 17, 2015

Related: Perhaps it would be helpful to perform additional initial cc validation (cvv/exp/name) on the client side using the stripe.payments script.

Another thing I've noticed on server validation is when actionable errors are returned, it blanks out the entire form so you have to re-enter everything again.

@DevinWalker
Copy link
Member Author

I noticed the same issue with blanking fields. That can be annoying for users. I agree we need some client side validation. Is stripe payments script you mentioned something specific only to the Stripe gateway or can that be used cross-gateway?

@DevinWalker
Copy link
Member Author

Bumping milestone...

@DevinWalker DevinWalker modified the milestones: 1.4 Milestone, 1.3 Milestone Sep 17, 2015
@pryley
Copy link
Contributor

pryley commented Sep 17, 2015

Oh, I meant the jquery.payment script (it's by the stripe team) that Give uses to validate the CC number also offers basic validation logic for cvc and expiry.

E.g. http://stripe.github.io/jquery.payment/example/

@DevinWalker
Copy link
Member Author

Gotcha

@DevinWalker
Copy link
Member Author

@DevinWalker
Copy link
Member Author

@pryley "Perhaps it would be helpful to perform additional initial cc validation (cvv/exp/name) on the client side using the stripe.payments script."

  • I totally agree...

@DevinWalker DevinWalker modified the milestones: 1.3.1, 1.4 Milestone Oct 15, 2015
@DevinWalker DevinWalker self-assigned this Oct 15, 2015
@DevinWalker
Copy link
Member Author

I'm going to see if I can get this into 1.3.1

@DevinWalker DevinWalker changed the title Modal Error Reporting Bug: CC validations don't reopen modal Server side validation flags don't reopen modal or slide down panel Oct 15, 2015
@DevinWalker DevinWalker mentioned this issue Oct 15, 2015
@DevinWalker DevinWalker changed the title Server side validation flags don't reopen modal or slide down panel Server side validation errors don't reopen modal or slide down panel Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants