Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bindgen dependency #425

Closed
kkysen opened this issue May 31, 2022 · 2 comments · Fixed by #442
Closed

Update bindgen dependency #425

kkysen opened this issue May 31, 2022 · 2 comments · Fixed by #442
Assignees
@fw-immunant

Comments

@kkysen
Copy link
Contributor

kkysen commented May 31, 2022

bindgen currently generates layout tests that invoke UB, specifically nullptr derefs (see rust-lang/rust-bindgen#1651). These are warned by rustc and may be errors soon. A fix (rust-lang/rust-bindgen#2203 on 5/17/2022) has already been merged, but hasn't landed in a release yet. So we should update our bindgen dependencies as soon as a new release lands.
@fw-immunant fw-immunant changed the title Update bindgen dependency as soon as the next version is released Update bindgen dependency when it next releases Jun 6, 2022
@fw-immunant
Copy link
Contributor

Bindgen 0.60.1 just came out; I'll bump our dep prior to our pending 0.16.1 release.

@fw-immunant fw-immunant self-assigned this Jun 6, 2022
@fw-immunant fw-immunant changed the title Update bindgen dependency when it next releases Update bindgen dependency Jun 6, 2022
@kkysen
Copy link
Contributor Author

kkysen commented Jun 7, 2022

Great! I just checked; 0.60 fixes the issue.

@kkysen kkysen mentioned this issue Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fw-immunant fw-immunant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated bindgen, which fixes the generated nullptr derefs in bindgen tests. immunant/c2rust
2 participants
@kkysen @fw-immunant