Refactor Layered Architecture

[iluwatar]

Description

Layered Architecture example has some code smells.

CakeInfo - 'Optional' used as type for field 'id'
CakeLayerInfo - 'Optional' used as type for field 'id'
CakeToppingInfo - 'Optional' used as type for field 'id'

Acceptance Criteria

• Code smells fixed

[ankurnotwarikoo]

Willing to work on this.
However in my sts I am unable to see the code smells as such. Followed the instructions mentioned here :-
https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

Could only see identation issues as such.
Please let me know how do I proceed to resolve this.
P.S. - Interested to contribute to this repo !

[iluwatar]

Don't know about other IDEs, but in IntelliJ IDEA you can reproduce the warnings by using command 'Analyze - Inspect Code' on the layered-architecture module.

[ankurnotwarikoo]

Could you assign this issue to me? This is my first time contributing, so I also need some guidance on how to commit and raise a pull request. Thank you!

[iluwatar]

Sure @ankurnotwarikoo Here are a couple of good starting points to get started with Github and this project:

• https://docs.github.com/en/get-started
• https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute

[ankurnotwarikoo]

@iluwatar - I am done with the code fixes. However, format the code using checkstlye plugin in Intellij and hence unable to surpass the validation of code.
Do let me know if there's some checkstyle.xml on which defines the basis of formatting of file.

[iluwatar]

Checkstyle is configured here: https://github.com/iluwatar/java-design-patterns/blob/master/pom.xml#L334-L356

It uses built-in Google Checks. We have added some of our own rule suppressions.

IDE instructions have some hints on how to work with Checkstyle https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions

[iluwatar]

Noticed that we have a partly duplicate issue #2936

[stale]

This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.

[abhishek-singh0710]

Can this issue be assigned to me?

[abhishek-singh0710]

Also I'm sorry if this seems like a poor question but are we only concerned with the optional type given to the ids of those three classes and none other?

[PALASH2201]

I checked the concerned code files, I guess the code smells are fixed. The optional fields have been changed.

[abhishek-singh0710]

Ok. Thanks for letting me know.

[PALASH2201]

Yea, no issues

[pujakarakoti07]

Could you please assign this issue to me?

[iluwatar]

Fixed in #2988