Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trigonometric functions on Angles #151

Closed
nathanielknight opened this issue Jun 18, 2019 · 2 comments
Closed

Support trigonometric functions on Angles #151

nathanielknight opened this issue Jun 18, 2019 · 2 comments

Comments

@nathanielknight
Copy link

Is there a good way to support trigonometric functions on Angle quantities? It seems like converting them to radians in floating point, calling the relevant std trig function, and returning a Ratio quantity (with Results in the right places to deal with Floating Point Weirdness and domain violations) would be useful.

If that's something that wouldn't be too hard to implement, I could try to add it.

@iliekturtles
Copy link
Owner

This can be done and I've been meaning to add a new issue with details but haven't had time. See #144 (comment) where this was discussed recently. If you want to submit a PR that would be great!

@nathanielknight nathanielknight changed the title Support trigonometric functions on Angles? Support trigonometric functions on Angles Jun 19, 2019
@nathanielknight
Copy link
Author

Great to hear 😄.

I'll see if I can get one method working and open a WIP pull request so there's something concrete to comment on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants