Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TPCSDAction #261

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Update TPCSDAction #261

merged 4 commits into from
Dec 2, 2022

Conversation

danieljeans
Copy link
Contributor

BEGINRELEASENOTES

  • bug fix: no longer carry over energy to next event (sometimes affected lowpt hits)
  • address one FIXME: create highpt hits even if steps have not passed the padrow centre
  • some slight code cleanup and reorganisation to hopefully make it clearer to read
    ENDRELEASENOTES

@danieljeans
Copy link
Contributor Author

hmm, some problems. I'll look into it next week.

tmadlener
tmadlener reviewed Nov 25, 2022
View reviewed changes
plugins/TPCSDAction.cpp Outdated
G4int CurrentCopyNumber{}; ///< copy number of the preStepPoint's TouchableHandle for the cumulative energy deposit


G4Step* previousStep{};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
G4Step* previousStep{};
G4Step GEANT4_CONST_STEP* previousStep{};

I think this would be the correct placement of the const, in order have the pointer modifiable, but the pointed to G4Step immutable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmadlener thanks!

@tmadlener tmadlener merged commit 61be77d into key4hep:master Dec 2, 2022
@tmadlener tmadlener mentioned this pull request Jan 12, 2023
Closed
BrieucF pushed a commit to BrieucF/k4geo that referenced this pull request Jun 13, 2023
@danieljeans @BrieucF
Update TPCSDAction (key4hep#261)
5b9946f 
* fix carry over of energy to next event. Create hits when steps don't cross padrow centre. Light code reorganisation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieljeans @tmadlener