Software compensation energy correction externalized #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correction. Software compensation parameters added in processor parameters : weights, bins and final energy density value.
|
This PR is also related to PR19 in LCContent package : PandoraPFA/LCContent#19 |
…gy, m_minCleanHitEnergyFraction and m_minCleanCorrectedHitEnergy for software compensation in main settings
|
This builds on my computer without problems. Should we wait for the nightly build with the new LCContent ? |
andresailer
approved these changes
Oct 14, 2017
|
restarted the build with new nightly, passing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES