Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include JAR files in IKVM.NET.Sdk #326

Closed
wasabii opened this issue May 17, 2023 · 1 comment · Fixed by #351
Closed

Include JAR files in IKVM.NET.Sdk #326

wasabii opened this issue May 17, 2023 · 1 comment · Fixed by #351
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@wasabii
Copy link
Contributor

wasabii commented May 17, 2023

A conversation I had on Discord with @AliveDevil resulted in this.

IKVM.NET.Sdk should support the inclusion of .jar files along side it's existing support for .class and .java files. This will assist @AliveDevil with his project. But also, it's the right place to put it. The goal of IKVM.NET.Sdk is to be a .NET Project type, which produces exactly one output assembly (like every other .NET project type), and there's nothing wrong with it being able to source the input for that production from multiple different types of files. This can be used by users to convert existing JAR files to Assemblies for the purposes of export/redistribution. IkvmReference isn't appropriate for this, because it's geared towards consuming Java libraries for the purpose of using them in an existing project, not for exporting or publishing them.

@wasabii wasabii self-assigned this May 17, 2023
@wasabii wasabii added enhancement New feature or request good first issue Good for newcomers labels May 17, 2023
@wasabii
Copy link
Contributor Author

wasabii commented May 17, 2023

Decisions for now:

Compile item group continues to include things compiled with javac (or Kotlin!)

Convert item group includes things compiled with ikvmc. That includes raw .class files and .jar files. Replaces Class itemgroup.

The _CompileCore stage hands off to CompileJava -> Convert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant