Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support magnet links that contain trackers with DHT disabled #80

Closed
av-gal opened this issue Feb 8, 2024 · 1 comment · Fixed by #85
Closed

Support magnet links that contain trackers with DHT disabled #80

av-gal opened this issue Feb 8, 2024 · 1 comment · Fixed by #85

Comments

@av-gal
Copy link

av-gal commented Feb 8, 2024

Magnet links may contain (a list of) trackers. Most magnet links don't contain any, relying solely on the DHT to find peers.

The current process for adding magnet URLs always bails if DHT is disabled, because it assumes that it will not be able to retrieve the torrent's metainfo without the DHT feeding it peers. Rqbit currently doesn't contact trackers until we've checked the torrent and it knows how many bytes left to report to the tracker.

Querying a tracker only uses the infohash, and would provide peers which we could try to download the metadata from. It's safe to report we haven't uploaded or downloaded anything yet, because this magnet still hasn't been added.

@ikatson
Copy link
Owner

ikatson commented Feb 9, 2024

Thanks for very detailed and well written issues (also #79). Agree that both would be worth implementing.
I'd be happy to merge pull requests on them, let me know if there's any interest.
Otherwise maybe someday I'll get to it, too busy these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants