Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added embroider-safe to ember-try scenarios #79

Merged
merged 4 commits into from
Apr 22, 2021
Merged

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Apr 22, 2021

Description

I followed the Addon Author Guide to understand what I could do to prepare for Embroider landing.

I wanted to add both embroider-safe and embroider-optimized scenarios, but the latter wouldn't pass in CI. There may be two explanations:

  1. I was using v0.4.0 of ember-element-helper.

    Unsafe dynamic component: cannot statically analyze this expression in $TMPDIR/embroider/6871bd/components/container-query.hbs/container-query.hbs

    Updating the addon to v0.5.0 (in Updated ember-element-helper to v0.5.0 #80) fixed the error above.

  2. ember-css-modules, which is used in the demo app, is not compatible with Embroider yet (Embroider compatibility salsify/ember-css-modules#140, Embroider with staticComponents: true not working with pods components salsify/ember-css-modules#160)

    Unable to resolve local class names from dummy/components/navigation-menu/index.css; does the styles file exist?

I tried changing the demo app's components folder structure from nested to flat, in case this might help Embroider understand ember-css-modules. Changing the folder structure didn't seem to have an effect.

For now, let's check just the embroider-safe scenario.

References

@ijlee2 ijlee2 force-pushed the add-embroider-test-setup branch 2 times, most recently from 43667c5 to 8effd00 Compare April 22, 2021 10:52
… testing embroider

Error: Unable to resolve local class names from dummy/tests/integration/components/container-query/splattributes-test.css; does the styles file exist?
@ijlee2 ijlee2 changed the title Added embroider-optimized and embroider-safe to ember-try scenarios Added embroider-safe to ember-try scenarios Apr 22, 2021
@ijlee2 ijlee2 marked this pull request as ready for review April 22, 2021 12:40
@ijlee2 ijlee2 added the enhance: documentation Issue asks for better documentation (e.g. README, code, tests) label Apr 22, 2021
@ijlee2 ijlee2 merged commit a1bdc83 into main Apr 22, 2021
@ijlee2 ijlee2 deleted the add-embroider-test-setup branch April 22, 2021 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: documentation Issue asks for better documentation (e.g. README, code, tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant