Updated dependencies (Part 2) #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that the lockfile lists ember-source just once
ijlee2
commented
Jun 7, 2024
| @@ -95,6 +95,7 @@ | |||
| "@types/ember__service": "^4.0.9", | |||
| "babel-plugin-ember-template-compilation": "^2.2.5", | |||
| "concurrently": "^8.2.2", | |||
| "ember-source": "^5.9.0", | |||
There was a problem hiding this comment.
Ideally, I think ember-element-helper would remove ember-source from peerDependencies, because I could get docs-app to run by uninstalling ember-element-helper.
ijlee2
commented
Jun 7, 2024
pnpm-lock.yaml
Outdated
Comment on lines
7848
to
7909
| /ember-source@5.9.0(@babel/core@7.24.7)(@glimmer/component@1.1.2)(@glint/template@1.4.0)(rsvp@4.8.5): | ||
| resolution: {integrity: sha512-sZdrRxsNJq49N+GlRpkrUfBagiCw5OUngXUcJO7tvoWPLTvO8RRip+1L2B868YkxlmSq22hLci9tgQUdmPmcXQ==} | ||
| engines: {node: '>= 16.*'} | ||
| peerDependencies: | ||
| '@glimmer/component': ^1.1.2 | ||
| dependencies: | ||
| '@babel/helper-module-imports': 7.24.7(supports-color@8.1.1) | ||
| '@ember/edition-utils': 1.2.0 | ||
| '@glimmer/compiler': 0.92.0 | ||
| '@glimmer/component': 1.1.2(@babel/core@7.24.7) | ||
| '@glimmer/destroyable': 0.92.0 | ||
| '@glimmer/env': 0.1.7 | ||
| '@glimmer/global-context': 0.92.0 | ||
| '@glimmer/interfaces': 0.92.0 | ||
| '@glimmer/manager': 0.92.0 | ||
| '@glimmer/node': 0.92.0 | ||
| '@glimmer/opcode-compiler': 0.92.0 | ||
| '@glimmer/owner': 0.92.0 | ||
| '@glimmer/program': 0.92.0 | ||
| '@glimmer/reference': 0.92.0 | ||
| '@glimmer/runtime': 0.92.0 | ||
| '@glimmer/syntax': 0.92.0 | ||
| '@glimmer/util': 0.92.0 | ||
| '@glimmer/validator': 0.92.0 | ||
| '@glimmer/vm': 0.92.0 | ||
| '@glimmer/vm-babel-plugins': 0.92.0(@babel/core@7.24.7) | ||
| '@simple-dom/interface': 1.4.0 | ||
| babel-plugin-debug-macros: 0.3.4(@babel/core@7.24.7) | ||
| babel-plugin-ember-template-compilation: 2.2.5 | ||
| babel-plugin-filter-imports: 4.0.0 | ||
| backburner.js: 2.8.0 | ||
| broccoli-concat: 4.2.5 | ||
| broccoli-debug: 0.6.5 | ||
| broccoli-file-creator: 2.1.1 | ||
| broccoli-funnel: 3.0.8 | ||
| broccoli-merge-trees: 4.2.0 | ||
| chalk: 4.1.2 | ||
| ember-auto-import: 2.7.3(@glint/template@1.4.0) | ||
| ember-cli-babel: 7.26.11 | ||
| ember-cli-get-component-path-option: 1.0.0 | ||
| ember-cli-is-package-missing: 1.0.0 | ||
| ember-cli-normalize-entity-name: 1.0.0 | ||
| ember-cli-path-utils: 1.0.0 | ||
| ember-cli-string-utils: 1.1.0 | ||
| ember-cli-typescript-blueprint-polyfill: 0.1.0 | ||
| ember-cli-version-checker: 5.1.2 | ||
| ember-router-generator: 2.0.0 | ||
| inflection: 2.0.1 | ||
| route-recognizer: 0.3.4 | ||
| router_js: 8.0.5(route-recognizer@0.3.4)(rsvp@4.8.5) | ||
| semver: 7.6.2 | ||
| silent-error: 1.1.1 | ||
| simple-html-tokenizer: 0.5.11 | ||
| transitivePeerDependencies: | ||
| - '@babel/core' | ||
| - '@glint/template' | ||
| - rsvp | ||
| - supports-color | ||
| - webpack | ||
| dev: false | ||
|
|
||
| /ember-source@5.9.0(@babel/core@7.24.7)(@glimmer/component@1.1.2)(@glint/template@1.4.0)(rsvp@4.8.5)(webpack@5.91.0): |
There was a problem hiding this comment.
The second entry of ember-source (with a slightly difference set of dependencies, e.g. webpack is missing in the first entry) caused the following build error in docs-app:
docs-app@5.0.9 (dev)-> ember-container-query@5.0.9 -> ember-element-helper@0.8.6
sees peerDep ember-source@5.9.0
at /Users/isaaclee/Documents/GitHub/ember-container-query/node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@glint+template@1.4.0_rsvp@4.8.5/node_modules/ember-source
but docs-app@5.0.9 is using ember-source@5.9.0
at /Users/isaaclee/Documents/GitHub/ember-container-query/node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@glint+template@1.4.0_rsvp@4.8.5_webpack@5.91.0/node_modules/ember-source
docs-app@5.0.9 (dev)-> ember-container-query@5.0.9 -> ember-element-helper@0.8.6 -> @embroider/util@1.13.0
sees peerDep ember-source@5.9.0
at /Users/isaaclee/Documents/GitHub/ember-container-query/node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@glint+template@1.4.0_rsvp@4.8.5/node_modules/ember-source
but docs-app@5.0.9 is using ember-source@5.9.0
at /Users/isaaclee/Documents/GitHub/ember-container-query/node_modules/.pnpm/ember-source@5.9.0_@babel+core@7.24.7_@glimmer+component@1.1.2_@glint+template@1.4.0_rsvp@4.8.5_webpack@5.91.0/node_modules/ember-source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follows up on #232.