Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change location_id to pop_id #17

Closed
AHsu98 opened this issue Feb 17, 2023 · 1 comment
Closed

Change location_id to pop_id #17

AHsu98 opened this issue Feb 17, 2023 · 1 comment

Comments

@AHsu98
Copy link
Contributor

AHsu98 commented Feb 17, 2023

location_id in dataframe splitting is a bad term--we should change it to the term pop_id or population_id to generally refer to the subpopulation that we are splitting (whether it is a country, or age group, both, etc.) Also, we can have that as an input (using possibly a list with indexing for multiple columns at once, since we have to send it to a tuple first if we want to select by both age and location).

@AHsu98
Copy link
Contributor Author

AHsu98 commented Feb 19, 2023

Actually, demographic_id is probably the best terminology as the most general term for a group of people sharing some similar traits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant