Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: custom bech32 address prefixes #93

Closed
nylira opened this issue Jul 30, 2020 · 0 comments · Fixed by #104
Closed

Feature request: custom bech32 address prefixes #93

nylira opened this issue Jul 30, 2020 · 0 comments · Fixed by #104
Assignees
@fadeev
Labels
type:new To implement new feature.

Comments

@nylira
Copy link
Contributor

nylira commented Jul 30, 2020 •
edited by sync-by-unito bot
Loading

When building a new blockchain, developers would likely want to define new bech32 address prefixes for addresses and public keys like these: https://docs.cosmos.network/master/spec/addresses/bech32.html#hrp-table

image

The Cosmos SDK does seem to support customizing these prefixes, added in this PR by @cwgoes cosmos/cosmos-sdk#2614

Here is an example implementation of this change a SDK-based blockchain:
cybercongress/go-cyber@1026309

One thing I just thought of that is that this might break compatibility with wallets and other tools that only work with cosmos1 prefixed addresses. But that seems to be their problem, not ours.
@nylira nylira added the type:new To implement new feature. label Jul 30, 2020
@fadeev fadeev mentioned this issue Aug 2, 2020
Merged
@fadeev fadeev self-assigned this Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fadeev fadeev

Labels
type:new To implement new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added custom bech32 address prefixes ignite/cli
2 participants
@nylira @fadeev