-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify protoanalysis
testdata
#1546
Comments
The |
I agree on Denis, I think it's pretty important to keep a full test that checks everything for complex modules. Otherwise, we'll be basically lowering the test coverage. |
We should detect what are all the edge cases in proto to handle them and have 100% coverage.
It's unnecessarily too complex to maintain if we want to extend |
Yes, that also makes sense as long as we cover all the edge cases in liquidity. |
I think we can wait for now, it's not 100% sure we will need to extend those capabilities but it could be if we want to move to scaffolder that doesn't depend on any placeholder in proto |
Is your feature request related to a problem? Please describe.
The current testdata used to test
protoanalysis
methods is the entireliquidity
module proto sources. Any specific reason to have this test data?The sources are big and it makes it difficult to maintain the tests when a new feature must be added. For example, the format of the
Parse
method is modifiedDescribe the solution you'd like
We should simplify a lot this testdata and still make it reliable for tests.
For example, keeping only 3 txs, 3 queries and 3 messages in
liquidity.proto
should be already sufficient to testParse
method effectively.The text was updated successfully, but these errors were encountered: