Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Pagination Bullets #848

Closed
nshki opened this issue Mar 10, 2018 · 6 comments
Closed

[Component] Pagination Bullets #848

nshki opened this issue Mar 10, 2018 · 6 comments

Comments

@nshki
Copy link
Member

nshki commented Mar 10, 2018

Overview

We are looking for an awesome human to build this out as a React component, preferably within Storybook. You can view and get details (colors, dimensions, export SVGs, etc.) by visiting the Figma designs and creating a free account.

This is part of the app redesign (#691).

Screenshot from the Figma document:

screenshot 2018-03-10 at 12 06 07 pm

@anGie44
Copy link

anGie44 commented Mar 12, 2018

@nshki i'd like to claim this issue! how can i join & contribute? sent an email to the join.ifme

@andrew-schutt
Copy link
Collaborator

Hey @anGie44! 👋

Thanks for jumping on this. Be sure to take a look at the contributing doc if you haven't https://github.com/ifmeorg/ifme/blob/master/CONTRIBUTING.md

And I am guessing that someone will get back to you shortly regarding getting added to the Slack channel. Might just be a little delay 😃

In the mean time though feel free to get going on this work and feel free to ask any questions on the issue. Hope that helps!

@nshki
Copy link
Member Author

nshki commented Mar 13, 2018

@anGie44 Great, take it away! I echo what @cartothemax says as well! I believe @julianguyen will add you as a collaborator/member so you can be assigned this task soon. :) Feel free to start though!

@prateksha prateksha self-assigned this Mar 16, 2018
@prateksha
Copy link
Member

@nshki Just wanted to clarify something. When we click/hover on Pagination 2 and 3 , should it change state to look like 1?

@ludamillion
Copy link
Contributor

Not sure just how important this still is but I took a swing at it. The PR is here => #1261

@julianguyen
Copy link
Member

Closing this cause we got rid of pagination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants