Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive whitespace around tables #75

Closed
JayDaley opened this issue Dec 21, 2020 · 6 comments
Closed

Excessive whitespace around tables #75

JayDaley opened this issue Dec 21, 2020 · 6 comments
Labels
contractor Ask contractor to do it

Comments

@JayDaley
Copy link
Contributor

JayDaley commented Dec 21, 2020

For some unknown reason, tables have an additional 50px right margin and top margin set by:

@media (min-width: 620px)
.block-table {
margin: 50px 0;
border: 0;
overflow: auto;
width: calc(100% - 50px);

and

.block-table>table {
width: calc(100% - 50px);
overflow: auto;
}

If there is a table caption then this is added rather than sitting in the margin space, so there is no issue if the top margin is remove.

Both margins can go entirely.

@JayDaley
Copy link
Contributor Author

For very wide tables this will take them right up to the edge of the body, which may be acceptable, but if not then

max-width: 902px; 

Can be added to .block-table.

@JayDaley
Copy link
Contributor Author

I've reviewed this following the template refactoring and it is now just

@media (min-width: 576px)
.block-table {
margin: 50px 0;
border: 0;
width: calc(100% - 50px);
}

the margin and width attributes can be deleted.

@JayDaley JayDaley added the contractor Ask contractor to do it label Jun 30, 2021
@JayDaley
Copy link
Contributor Author

Assigned to contractor as it is not clear what the purpose of this 50px margin is.

@JayDaley JayDaley added internal Fix internally and removed contractor Ask contractor to do it labels Jun 30, 2021
@kesara kesara added contractor Ask contractor to do it and removed internal Fix internally labels Feb 24, 2022
@ghwood
Copy link
Collaborator

ghwood commented Feb 24, 2022

Screenshot of example from https://www.ietf.org/how/meetings/113/hotel/:
image

@ghwood
Copy link
Collaborator

ghwood commented May 17, 2022

A few other table example screenshots from https://www.ietf.org/about/administration/rfps-and-contracts/ and https://www.ietf.org/about/open-records/
image
image

@kesara
Copy link
Member

kesara commented Jun 22, 2022

Fix has been deployed to https://wwwdev.ietf.org/ with #196

@kesara kesara closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contractor Ask contractor to do it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants