Converted ExtSimAdapter to typed.
#1095
Open
+171
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastian-peter
requested changes
Feb 10, 2025
| Props( | ||
| new ExtSimAdapter(scheduler) | ||
| ) | ||
| sealed trait AdapterMessage extends ControlResponseMessageFromExt |
There was a problem hiding this comment.
Why not call this Request, which is a pekko convention we took over? So then, from other classes one would specify the message type as ExtSimAdapter.Request
Comment on lines
+208
to
211
| val extSimAdapter = context.spawn( | ||
| ExtSimAdapter(scheduler), | ||
| s"$index", | ||
| ) |
There was a problem hiding this comment.
Please pick an expressive actor name here. Beforehand, simonaActorOf took care of that by prepending the class name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1094