Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies between Event and Elements #11

Open
BartAdv opened this issue Jul 8, 2014 · 2 comments
Open

Dependencies between Event and Elements #11

BartAdv opened this issue Jul 8, 2014 · 2 comments

Comments

@BartAdv
Copy link
Contributor

BartAdv commented Jul 8, 2014

I've tried to add target function to get an element that caused an event. The Event module does not see the Elements (it's the other way around at the moment). I am wondering whether it wouldn't be better for the Event to depend on Elements (this would require to move onXXX functions there), but this would also require to remove abstract from Element, as its constructor would now be used in other module.

So maybe it's better to just merge those two? Any other ideas?

@raichoo
Copy link
Member

raichoo commented Jul 9, 2014

I don't think that removing abstract from Element would be a good idea. If you need to merge the two modules to get your stuff going, give it a shot. I'll check out the PR and will most likely merge it :) Go for it!

@BartAdv
Copy link
Contributor Author

BartAdv commented Jul 9, 2014

Yes, it would only expose the underlying Ptr. I will most likely merge them, but after some experiments with dependent events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants