Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing some logs from the process being proxied #7

Closed
igozali opened this issue Oct 12, 2020 · 2 comments
Closed

Exposing some logs from the process being proxied #7

igozali opened this issue Oct 12, 2020 · 2 comments

Comments

@igozali
Copy link

igozali commented Oct 12, 2020

Hi, thanks for writing this very useful utility! I had a question/feature request, hopefully this is not too bad of a place to submit it.

Right now, I've successfully used jhsingle-native-proxy to serve a notebook via Voila behind JupyterHub, and this is really nice as it allows me to take advantage of JupyterHub's authentication mechanism before allowing access to the Hub-managed service.

I was wondering if there's a good way to expose some of the logs of the process being proxied. Right now, in jhsingle-native-proxy, I see the --debug flag, which will set both the tornado app_log level to DEBUG, and pass debug=True to the tornado Application.

Would it be possible to get INFO level logs though? Right now, if I don't set the --debug argument, then all of my Voila logs seems to get swallowed by the proxy, but if I use the --debug flag, then it logs too much information.

@igozali igozali changed the title Exposing logs of the process being proxied Exposing some logs from the process being proxied Oct 12, 2020
@danlester
Copy link
Member

Thank you for this suggestion. Of course it is up to you whether to pass --debug all the way through to Voilà or not, but the --debug to jhsingle-native-proxy itself (and how to handle output from the sub-process e.g. Voilà) is definitely something that can be improved. Maybe it should be possible to instruct it to pass through all output from the sub-process or not. The level of logging from jhsingle-native-proxy itself could be controlled independently perhaps.

Anyway, yes, this is something I would like to look at in more detail. Thanks again for the ideas.

@danlester
Copy link
Member

Thanks again for this suggestion. In version 0.6.0, just released, the default is to pass through logs from the subprocess, and this can be switched off by passing --no-logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants