Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker image usage to README.md #58

Merged
merged 2 commits into from
Apr 3, 2018

Conversation

jnogol
Copy link
Collaborator

@jnogol jnogol commented Mar 28, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Noticing in #57 that Docker image usage was not clear enough, I've added a little explanation with a sample command.

Benefits

Docker image usage is clearer.

Possible Drawbacks

None

@a-zen
Copy link

a-zen commented Mar 29, 2018

Looks good :-)

@dortegau dortegau merged commit 51c717f into develop Apr 3, 2018
@jnogol jnogol deleted the bugs/readme_docker_explained branch April 17, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants