Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#177 Fixing unit tests when using Python <= 3.6 #178

Merged
merged 4 commits into from
Apr 13, 2020
Merged

#177 Fixing unit tests when using Python <= 3.6 #178

merged 4 commits into from
Apr 13, 2020

Conversation

dortegau
Copy link
Member

@dortegau dortegau commented Apr 12, 2020

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Benefits

Unit tests are passing using any Python version

Possible Drawbacks

New library (DeepDiff) has been added to requirements file. As this library is only used during unit tests, could be desirable to have two requirement files.

Applicable Issues

#177

@dortegau dortegau requested a review from juanriaza April 12, 2020 21:30
@dortegau dortegau merged commit 0df2919 into develop Apr 13, 2020
@dortegau dortegau deleted the bugs/177 branch April 13, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants