Fix test that fails intermittently under python 3.5 #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diffs can be slightly longer than the default limit. Disabling the limit makes it easier to debug test failures.
Dicts are not sorted in Python 3.5, so I adjusted a test that expects the keys will iterate in a certain order.
Merged
|
Fixes #177 |
|
Hello @mdelagrange, We have checked your PR, and we prefer not to merge because your solution is very platform specific (we prefer not to check Python versions in source code) and is not very versatile, as is checking two fields directly (facts and prometheus) and swapping the positions if are unordered. We have found a general solution using DeepDiff library, that you can check in: #178 Anyway, thanks a lot for your effort and contribution :) |
|
That’s fine! Thanks for putting together a more versatile solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Unit tests will fail intermittently under Python 3.5, because there is a test that expects dict keys to be in a particular order. That feature was not introduced until Python 3.6. This fix will adjust the key order within the test under Python 3.5.
This PR also makes
bin/prom2teamsexecutable.Benefits
Python 3.5 builds in Travis should start passing consistently. See https://travis-ci.org/github/idealista/prom2teams/builds/669700776 and https://travis-ci.org/github/idealista/prom2teams/builds/650821639 for examples of failing Python 3.5 builds.
Possible Drawbacks
This should have no effect on the application or on other tests.
Applicable Issues
None