Fixes #105 marshmallow.exceptions.ValidationError #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your PR and for using Prom2teams, @gjermy. Could you please add this change to the |
|
Hi @jnogol, sorry missed the changelog entry. Have added now. |
dortegau
requested review from
jmonterrubio,
jnogol,
jperera,
sorobon,
frantsao and
dortegau
dortegau
approved these changes
Feb 18, 2019
jnogol
approved these changes
Feb 19, 2019
jmonterrubio
approved these changes
Feb 19, 2019
sorobon
approved these changes
Feb 19, 2019
dortegau
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Cope with Prometheus alerts containing commonAnnotations, commonLabels, groupLabels and a groupKey at the Message level. See with_common_items.json
Allow arbitrary label names in message.commonAnnotations, message.commonLabels, message.groupLabels, alert.labels, alert.annotations.
Benefits
commonAnnotations etc - prometheus must have introduced these since the prom2teams integration was written.
Arbitrary labels: The prom2teams integration is otherwise tied to the particular label names coded into message_schema.py, which will likely not be same for other users alerting setups.
Possible Drawbacks
User can not access their own arbitrary label values via the template, but as long as all information wanted to be displayed in present in the fields which are set in class PrometheusAlert.py, then this shouldn't matter,
Applicable Issues
#105 marshmallow.exceptions.ValidationError