Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit Markd::Options class #54

Open
devnote-dev opened this issue Apr 9, 2023 · 0 comments
Open

Revisit Markd::Options class #54

devnote-dev opened this issue Apr 9, 2023 · 0 comments

Comments

@devnote-dev
Copy link
Contributor

I think that there could be some changes/improvements to the current Options class:

  • Removing unimplemented options: given that they're not used, there's no actual reason to have them in the class – having a TODO comment or similar in place would be better for whomever wants to implement them
  • Removing time: I understand the purpose but this is really something that users could implement themselves if they wanted that information, and it's relatively easy to do
  • Replace safe: I like this option, but it is quite restricting – if you wanted to allow table HTML and nothing else, there would be no way to do that without performing string manipulation post-rendering. I think it would be better to change this into something like sanitize which gives you options on what HTML elements you want to allow, there is a sanitize shard that would be great for this
  • Rename prettyprint: (this one isn't important, but pretty_print makes so much more sense here lol)

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant