Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREO2URDF – Add in idyntree the possibility to export xml blobs and sensors to the urdf #24

Closed
1 task done
Nicogene opened this issue May 11, 2023 · 4 comments
Closed
1 task done
Assignees
Labels
domain-software Related to Software team-fix Related to Team Fix

Comments

@Nicogene
Copy link
Member

Nicogene commented May 11, 2023

Task description

This task requires to make changes to idyntree:

Tasks

Preview Give feedback
  1. Nicogene

Definition of done

Xml blobs and sensors have been exported

cc @traversaro @pattacini

@Nicogene Nicogene added domain-software Related to Software team-fix Related to Team Fix labels May 11, 2023
@Nicogene Nicogene changed the title CREO2URDF – Add sensor to urdf FIXME ❌ CREO2URDF – Add sensor/xml blob to urdf FIXME ❌ May 11, 2023
@Nicogene Nicogene changed the title CREO2URDF – Add sensor/xml blob to urdf FIXME ❌ CREO2URDF – Add sensor/xml blob to urdf Jun 6, 2023
@Nicogene
Copy link
Member Author

Nicogene commented Jun 9, 2023

As discussed during the review meeting, we will tackle this when will have the urdf of an entire robot (MVP-3)

cc @pattacini @mfussi66

@Nicogene
Copy link
Member Author

@Nicogene Nicogene changed the title CREO2URDF – Add sensor/xml blob to urdf CREO2URDF – Add in idyntree the possibility to export xml blobs and sensors to the urdf Aug 24, 2023
@Nicogene
Copy link
Member Author

Nicogene commented Sep 7, 2023

Thanks to @traversaro is now possible to retrieve directly from the iDynTree::Model the list of sensors, see:

@Nicogene
Copy link
Member Author

Nicogene commented Sep 7, 2023

Today I started working on moving the logic for exporting the urdf of the sensors inside idyntree instead on doing it on the creo2urdf-side, but I discovered that I am missing several information that requires further changes/refactoring on idyntree side.

In particular I miss;

  • frame
  • measure_direction
  • sensorBlobs

The first two can be "deducted" from other informations already carried by the iDynTree::SixAxisForceTorqueSensor but the latter requires changes in the class itself, in the parsing stage (How we distinguish a xmlblob to something else inside the xml?) and finally in the export stage.

Since on creo2urdf side this operation is quite simple because we directly got these informations from the yaml, with @mfussi66 agreed that work for introducing this feature in idyntree is not worthy and maybe it goes also out of scope of what a sensor is inside idyntree, because usually the xml blobs are gazebo-related.

Given that we can define this activity concluded already in

cc @pattacini @traversaro

@Nicogene Nicogene closed this as completed Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-software Related to Software team-fix Related to Team Fix
Projects
None yet
Development

No branches or pull requests

2 participants