SSH config is not loaded when sshConfigPath is not set

[sparanoid]

Description

SSH config is not loaded when sshConfigPath is not set in settings.

Steps to Reproduce

1. Leave sshConfigPath unset.
2. Use custom hostname like "host": "webserver-la-2" in .ftpconfig.
3. Try to connect to the server then you will got connection error

Expected behavior:
Supposed to read ~/.ssh/config by default, connection should be made without any issue.

Actual behavior:
Connection error

Reproduces how often:
100%

Versions

$ atom --version
Atom    : 1.25.0
Electron: 1.7.11
Chrome  : 58.0.3029.110
Node    : 7.9.0

Additional Information

N/A

[bearpaw]

Hi @sparanoid , can you share your .ftpconfig file and ~/.ssh/config file? Thank you very much!

[sparanoid]

@bearpaw

In ~/.ssh/config:

Host custom-hostname
  HostName __host_ip_here__
  User ec2-user
  IdentityFile ~/.ssh/aws.pem

In .ftpconfig:

{
    "protocol": "sftp",
    "host": "custom-hostname",
    "port": 22,
    "user": "ec2-user",
    "pass": "",
    "promptForPass": false,
    "remote": "/srv/",
    "local": "",
    "agent": "",
    "privatekey": "/path/to/your/key",
    "passphrase": "",
    "hosthash": "",
    "ignorehost": true,
    "connTimeout": 10000,
    "keepalive": 10000,
    "keyboardInteractive": false,
    "watch": [],
    "watchTimeout": 500
}

Actually user field in .ftpconfig is ignored, it can be anything or just left empty since we define it in SSH config.

[icetee]

Settings must specify the path for the configuration. I changed the default value, but only next version included. (Look at this)