Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operations Broken in PaneGrid #1532

Closed
2 tasks done
rs017991 opened this issue Nov 13, 2022 · 0 comments · Fixed by #1533
Closed
2 tasks done

Operations Broken in PaneGrid #1532

rs017991 opened this issue Nov 13, 2022 · 0 comments · Fixed by #1533
Labels
bug Something isn't working shell
Milestone

Comments

@rs017991
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues.

Is this issue related to iced?

  • My hardware is compatible and my graphics drivers are up-to-date.

What happened?

When the target of an Operation lies anywhere within a PaneGrid, the operation is silently ignored.

You can reproduce the issue by running this modified example.
I've added a 'snapTo 0.0' whenever you click a Pane, so you can:

  1. You can resize the window such that the scrollbar appears
  2. Scroll that bar down a bit.
  3. Then, clicking anywhere in any pane should cause all scrollbars to snap to the top (but doesn't without the fix))

Note: I removed the responsive part of the example for this reproduction, because it also breaks Operations. I'll open a separate issue for that.

I think the fix is pretty straightforward (PaneGrid is simply missing its operate method), so I'll put out a PR for this shortly.

What is the expected behavior?

Operations should work within PaneGrids

Version

master

Operative System

Windows

Do you have any log output?

No response

@rs017991 rs017991 added the bug Something isn't working label Nov 13, 2022
@hecrj hecrj added the shell label Nov 13, 2022
@hecrj hecrj added this to the 0.6.0 milestone Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shell
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants