From f9d2cc04120d1ad842681ce02ecf8c596bad26fc Mon Sep 17 00:00:00 2001 From: Derek Wang Date: Tue, 19 Jan 2021 09:29:38 -0800 Subject: [PATCH] fix(sensor-controller): Return err when a sensor spec is invalid. Fixes #1017 (#1018) Signed-off-by: Derek Wang --- .github/workflows/release.yml | 1 - controllers/sensor/controller.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 2949bd7a4056..70d80a211d99 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -6,7 +6,6 @@ on: - 'v*' branches: - master - - quay-test jobs: release: diff --git a/controllers/sensor/controller.go b/controllers/sensor/controller.go index fc2bc8693972..ebe31aaf4b1f 100644 --- a/controllers/sensor/controller.go +++ b/controllers/sensor/controller.go @@ -91,6 +91,7 @@ func (r *reconciler) reconcile(ctx context.Context, sensor *v1alpha1.Sensor) err err := ValidateSensor(sensor) if err != nil { log.Errorw("validation error", "error", err) + return err } args := &AdaptorArgs{ Image: r.sensorImage,