Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct target frameworks #67

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

pz1337
Copy link
Collaborator

@pz1337 pz1337 commented Aug 19, 2022

Please check if the PR fulfills these requirements

  • I made sure that my code builds (VisualStudio & cake script: build.ps1)
  • I merged the master into this branch before pushing
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?** (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

close #66

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications

Other information

@codecov-commenter
Copy link

Codecov Report

Merging #67 (651d483) into main (1ddf09e) will increase coverage by 0.27%.
The diff coverage is n/a.

❗ Current head 651d483 differs from pull request most recent head efc26c0. Consider uploading reports for the commit efc26c0 to get more accurate results

@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   78.04%   78.31%   +0.27%     
==========================================
  Files          21       21              
  Lines         738      738              
  Branches       93       93              
==========================================
+ Hits          576      578       +2     
  Misses        132      132              
+ Partials       30       28       -2     
Impacted Files Coverage Δ
src/Yaapii.Xml/SourcesEmbedded.cs 100.00% <0.00%> (+7.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct target frameworks
2 participants