Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] add emitter_kwargs to optimizer ask and tell #136

Open
btjanaka opened this issue Jul 1, 2021 · 1 comment · Fixed by #159
Open

[FEATURE REQUEST] add emitter_kwargs to optimizer ask and tell #136

btjanaka opened this issue Jul 1, 2021 · 1 comment · Fixed by #159
Labels
API enhancement New feature or request

Comments

@btjanaka
Copy link
Member

btjanaka commented Jul 1, 2021

Description

In order to make ask and tell more flexible, we can add emitter kwargs that get passed in. If the kwargs is a single dict, we pass those kwargs to all the emitters. If it is a list of dicts, each entry holds kwargs for one emitter.

@btjanaka btjanaka added the enhancement New feature or request label Jul 1, 2021
@btjanaka btjanaka added this to the v0.4.0 milestone Jul 3, 2021
@btjanaka btjanaka added the API label Jul 5, 2021
@btjanaka btjanaka removed this from the v0.4.0 milestone Jul 16, 2021
@btjanaka btjanaka reopened this Jul 16, 2021
@btjanaka
Copy link
Member Author

Added in #159 but reverted in #167 as we are still thinking about the behavior of this feature -- for instance, what if we had emitters that take in an argument but other emitters that did not take in the argument, but we did not want to have to duplicate the kwargs in a list?

@btjanaka btjanaka modified the milestone: v0.6.0 Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant