-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PeriodSerializer not working with midnight DATE-TIME. #564
Comments
Please double-check the new version merged with #595 |
@axunonb: Yes, the problem still exists. |
This was referenced Oct 15, 2024
@axunonb I think we should reopen this. Don't think I can do that myself. Started working on a PR but could take a while until I find enough time, as all these little issues are interconnected. |
@axunonb Thanks for the invitation! Reopened the relevant issues. |
Fixed with #638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PeriodSerializer doesn't deserialize a period's duration correctly if the start IDateTime's time is set to midnight.
E.g. the following period string should be serialized to a period with a duration of 6H but actually has 1D:
20180219T000000Z/PT6H
Can be reproduced via the following test case:
The problem boils down to
Period
automatically assuming a duration of 1D if the time component is zero.Also see similar code in CalDateTime.cs and a related issue in #602.
The text was updated successfully, but these errors were encountered: