Issues found on the everest ssystem

[branupama]

I compared PIM files of new vpd-manager with the old released code.
Found the differences for the following files,

1. DI property is missing in ddimm & iddimm parsers
   chassis/motherboard/dimm6/com.ibm.ipzvpd.VINI
   chassis/motherboard/dimm2/com.ibm.ipzvpd.VINI

2. Available 'false' in new code for these dimes
   chassis/motherboard/dimm15/xyz.openbmc_project.State.Decorator.Availability
   chassis/motherboard/dimm52/xyz.openbmc_project.State.Decorator.Availability chassis/motherboard/dimm38/xyz.openbmc_project.State.Decorator.Availability chassis/motherboard/dimm1/xyz.openbmc_project.State.Decorator.Availability chassis/motherboard/dimm12/xyz.openbmc_project.State.Decorator.Availability chassis/motherboard/dimm54/xyz.openbmc_project.State.Decorator.Availability chassis/motherboard/dimm40/xyz.openbmc_project.State.Decorator.Availability
   etc..

3. SlotNumber present in new code, which is '0' in old code chassis/motherboard/pcieslot5/pcie_card5/xyz.openbmc_project.Inventory.Decorator.Slot
   chassis/motherboard/pcieslot1/pcie_card1/xyz.openbmc_project.Inventory.Decorator.Slot
   chassis/motherboard/pcieslot10/pcie_card10/xyz.openbmc_project.Inventory.Decorator.Slot chassis/motherboard/pcieslot9/pcie_card9/xyz.openbmc_project.Inventory.Decorator.Slot chassis/motherboard/pcieslot8/pcie_card8/xyz.openbmc_project.Inventory.Decorator.Slot
   etc… card6, card4,

4. Present property 'false' in Old, 'true' in new code.
   chassis/motherboard/dasd_backplane/nvme8/drive8/xyz.openbmc_project.Inventory.Item
   chassis/motherboard/dasd_backplane/nvme6/drive6/xyz.openbmc_project.Inventory.Item

5. All properties values are empty
   chassis/motherboard/dasd_backplane/com.ibm.ipzvpd.VINI chassis/motherboard/dasd_backplane/xyz.openbmc_project.Inventory.Decorator.Asset
   Reason:
   /sys/bus/i2c/drivers/at24/27-0050/eeprom, error: Pre-Action failed
   As we expect gpio read value 0 (active-high) to be present. We reading presence line as 1, hence VPD collection is failing(pre-action).
   platform-fru-detect service is changing it to active-low.

6. File Not found
   chassis/motherboard/dasd_backplane/com.ibm.ipzvpd.VMPU
   chassis/motherboard/dasd_backplane/dp_connector0/xyz.openbmc_project.Inventory.Connector.Port
   chassis/motherboard/dasd_backplane/dp_connector1/xyz.openbmc_project.Inventory.Connector.Port
   chassis/motherboard/pcieslot2/pcie_card2/cxp_bot/xyz.openbmc_project.Inventory.Item
   chassis/motherboard/pcieslot2/pcie_card2/cxp_bot/xyz.openbmc_project.Inventory.Connector.Port chassis/motherboard/pcieslot2/pcie_card2/cxp_bot/xyz.openbmc_project.State.Decorator.OperationalStatus
   etc…
   Reason:
   Missing {"extraInterfaces"-> "xyz.openbmc_project.Inventory.Connector.Port": null} in JSON for Everest for following FRUs, "/dp_connector0", "/dp_connector1", "/pcie_card2/cxp_top", "/pcieslot1/pcie_card1/cxp_bot"

7. "pcie_card/cxp_bot" object path is not being populated on DBus for any pcie cards.
   Reason:
   "/sys/bus/i2c/drivers/at24/17-0050/eeprom" has CC value as CC": [
   50,
   67,
   70,
   53
   ],
   but CCIN we mentioned in the JSON ("ccin": ["6B99"],) they are not matching.
   master branch everest JSON doesn't has CCIN, but we have in new JSON.
   So cxp object path is not populated.

8. Bus & address is present in new code
   chassis/motherboard/pcieslot1/pcie_card1/xyz.openbmc_project.Inventory.Decorator.I2CDevice
   chassis/motherboard/pcieslot10/pcie_card10/xyz.openbmc_project.Inventory.Decorator.I2CDevice
   etc...

9. Pretty name missing for fans
   chassis/motherboard/fan0/xyz.openbmc_project.Inventory.Item
   chassis/motherboard/fan1/xyz.openbmc_project.Inventory.Item