Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @Configuration(proxyBeanMethods=false) wherever possible? #45

Closed
PascalSchumacher opened this issue Jan 26, 2020 · 4 comments
Closed

Comments

@PascalSchumacher
Copy link

PascalSchumacher commented Jan 26, 2020

What do you think about using ´@configuration(proxyBeanMethods=false)´ instead of @Configuration to avoid the (potentially expensive) generation of cglib proxies?

See: https://docs.spring.io/spring-framework/docs/current/javadoc-api/org/springframework/context/annotation/Configuration.html#proxyBeanMethods-- and: spring-projects/spring-boot#9068 for details.

By the way: Thank you very much for providing mq-jms-spring. 👍

@ibmmqmet
Copy link
Collaborator

Looks like it should work - I don't see anywhere that there's a breaking reason. And it's been done for some of the other components that have similar design patterns, so I'll look to make that change next time I do some updates.

@PascalSchumacher
Copy link
Author

I'll look to make that change next time I do some updates.

Thank you very much! Looking forward to it.

@ibmmqmet
Copy link
Collaborator

ibmmqmet commented Mar 2, 2020

Done in 2.2,5

@PascalSchumacher
Copy link
Author

Thank you very much! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants