Skip to content
This repository has been archived by the owner on Aug 14, 2024. It is now read-only.

Parser is a dependency but eslint-plugin is a peer dependency #158

Closed
Methuselah96 opened this issue Oct 23, 2020 · 5 comments · Fixed by #187
Closed

Parser is a dependency but eslint-plugin is a peer dependency #158

Methuselah96 opened this issue Oct 23, 2020 · 5 comments · Fixed by #187
Labels

Comments

@Methuselah96
Copy link

Is there a reason why @typescript-eslint/eslint-plugin is a peer dependency, but @typescript-eslint/parser is a dependency? I'd like for them both to be peer dependencies so that I can use matching versions.

@leethree
Copy link

agree. also @typescript-eslint/parser shouldn't be pinned to a specific version (as I commented on #153 (comment)). otherwise users won't be able to match the version between parser and plugin.

@Djaler
Copy link

Djaler commented Jan 3, 2021

@iamturns can you please change this?

@iamturns
Copy link
Owner

iamturns commented Feb 6, 2021

The reason @typescript-eslint/eslint-plugin is a peer dependency, is because all ESLint plugins must be installed locally. This is a limitation within ESLint itself. See RFC and progress

To help with this, I've just removed the peerDependency (see #187). This allows more flexibility with the version of eslint-plugin you want to install. Also, the dependencies are unpinned, so that you can keep @typescript-eslint/eslint-plugin and @typescript-eslint/parser versions in sync too.

Hope this helps. Cheers!

@iamturns
Copy link
Owner

iamturns commented Feb 6, 2021

🎉 This issue has been resolved in version 12.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@utrumo
Copy link

utrumo commented Aug 15, 2021

This issue has been resolved in version 12.0.1

The release is available on:

Your semantic-release bot

@typescript-eslint/parser must also be removed from dependencies for keeping @typescript-eslint/eslint-plugin and @typescript-eslint/parser versions in sync too. This module is already in peer dependencies eslint-config-aribnb and eslint-config-airbinb-base

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants