Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeekOfYear with weekStart 1 is off-by-one in some years #726

Closed
ChiefORZ opened this issue Nov 7, 2019 · 2 comments · Fixed by #769
Closed

WeekOfYear with weekStart 1 is off-by-one in some years #726

ChiefORZ opened this issue Nov 7, 2019 · 2 comments · Fixed by #769
Labels
released

Comments

@ChiefORZ
Copy link
Contributor

ChiefORZ commented Nov 7, 2019

We noticed, that in some years - we have an off-by-one error.
These cases are the year 2010 and 2016 - where the first week of the year has more than 4 days in the old year.

I created a PR for this #725
@hcwhan
Copy link
Contributor

hcwhan commented Jan 6, 2020

The ISO 8601 definition for week 01 is the week with the Gregorian year's first Thursday in it.
ISO 8601定义包含当年第一个星期四的那一周是第一个星期

dayjs('2021-01-01').week() === 1 is error

@iamkun iamkun mentioned this issue Jan 6, 2020
Merged
@iamkun
Copy link
Owner

iamkun commented Feb 4, 2020

🎉 This issue has been resolved in version 1.8.20 🎉

The release is available on:

Your semantic-release bot 📦🚀

@iamkun iamkun added the released label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix weekOfYear plugin to support yearStart locale for better wee… iamkun/dayjs
3 participants
@ChiefORZ @hcwhan @iamkun