Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d.ts] first parameter date is optional in isSame(), isBefore(), isAfter() #2272

Merged
merged 2 commits into from
Apr 16, 2023

Conversation

FourwingsY
Copy link
Contributor

@FourwingsY FourwingsY commented Mar 31, 2023

I don't know why this PR #1929 closed,
But it is quite useful to use birthday.isBefore() with no params in typescript.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #2272 (ea4c9f6) into dev (b87aa0e) will not change coverage.
The diff coverage is n/a.

❗ Current head ea4c9f6 differs from pull request most recent head e69bd82. Consider uploading reports for the commit e69bd82 to get more accurate results

@@            Coverage Diff            @@
##               dev     #2272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          183       183           
  Lines         2111      2111           
  Branches       555       554    -1     
=========================================
  Hits          2111      2111           
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@FourwingsY FourwingsY changed the title first parameter date is optional in isSame(), isBefore(), isAfter() [d.ts] first parameter date is optional in isSame(), isBefore(), isAfter() Mar 31, 2023
@iamkun iamkun merged commit 4d56f3e into iamkun:dev Apr 16, 2023
@iamkun
Copy link
Owner

iamkun commented Apr 16, 2023

thanks

@FourwingsY FourwingsY deleted the fix/optional-date-parameter branch April 26, 2023 01:40
github-actions bot pushed a commit that referenced this pull request Jun 2, 2023
## [1.11.8](v1.11.7...v1.11.8) (2023-06-02)

### Bug Fixes

* .format add padding to 'YYYY' ([#2231](#2231)) ([00c223b](00c223b))
* Added .valueOf method to Duration class ([#2226](#2226)) ([9b4fcfd](9b4fcfd))
* timezone type mark `date` parameter as optional ([#2222](#2222)) ([b87aa0e](b87aa0e))
* type file first parameter date is optional in isSame(), isBefore(), isAfter() ([#2272](#2272)) ([4d56f3e](4d56f3e))
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

🎉 This PR is included in version 1.11.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
ohsory1324 pushed a commit to ohsory1324/dayjs that referenced this pull request Dec 20, 2023
## [1.11.8](iamkun/dayjs@v1.11.7...v1.11.8) (2023-06-02)

### Bug Fixes

* .format add padding to 'YYYY' ([iamkun#2231](iamkun#2231)) ([00c223b](iamkun@00c223b))
* Added .valueOf method to Duration class ([iamkun#2226](iamkun#2226)) ([9b4fcfd](iamkun@9b4fcfd))
* timezone type mark `date` parameter as optional ([iamkun#2222](iamkun#2222)) ([b87aa0e](iamkun@b87aa0e))
* type file first parameter date is optional in isSame(), isBefore(), isAfter() ([iamkun#2272](iamkun#2272)) ([4d56f3e](iamkun@4d56f3e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants