Microsoft config: remove client secret, use custom redirect uri #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielittner
commented
Feb 22, 2018
| @@ -8,17 +8,17 @@ For further explanation, read the section on "Why is this app bad?" below. | |||
| This app demonstrate the use of the | |||
| [AppAuth for Android](https://github.com/openid/AppAuth-Android/) | |||
| library to interact with four identity providers (IDPs): Facebook, GitHub, | |||
| Google and Microsoft. While Google supports the current best-practices for | |||
| Google and Microsoft. While Google and Microsoft support the current best-practices for | |||
There was a problem hiding this comment.
Not sure if this is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to work you need to go to https://apps.dev.microsoft.com/#/application/fb7f3460-68b6-48f9-a272-71e1ebf39cd2 and enable the custom redirect uri in the Platforms -> Native application section. The PR uses the default one which is
msal<client id>://auth.closes #1