Brawlhalla screen is offset

[valters-tomsons]

Hey!

I'm trying to run Brawlhalla, but with galium-nine enabled, screen seems to render offset. Mouse is still detected where it should be.

Wine: 4.0 Staging
Driver: X.Org AMD Radeon (TM) R9 380 Series (TONGA, DRM 3.27.0, 4.20.6-zen1-1-zen, LLVM 7.0.1)
Driver Version: 4.5 (Compatibility Profile) Mesa 18.3.3

Screenshots:

[axeldavy]

Do you have the same issue if using the virtual desktop mode (see winecfg) ?

[dhewg]

Please attach a log with nine enabled: WINEDEBUG=d3d9nine wine $game 2>&1 | tee nine.log

Does it work with nine disabled?

[valters-tomsons]

Yes, it does work with nine disabled, but performance is subpar.
Yes, it does seem to work in virtual desktop mode.

The log: (without virtual desktop)
https://gist.github.com/FaithLV/4a1572c01f76dc9ba673085f4cf4f2ae

[dhewg]

Did you compile this project yourself?

[valters-tomsons]

Compiled from this: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=gallium-nine-git

[dhewg]

Ok nice. I pushed a test branch here https://github.com/iXit/wine-nine-standalone/commits/test
Can you try to make that aur build that? I think you just have to change it to
source=("git+https://github.com/iXit/wine-nine-standalone.git#test")
?

With that, do you get ClientToScreen failed? Does it work then?

[dhewg]

Oh, and do you have anything fancy on your X setup? Xwayland? dual gpu/monitor?

[valters-tomsons]

Hey, the test branch seems to be working fine! (sorry for the delay :( )

Only fancy thing I have is dual monitor setup like this:
1280x1024, 1920x1080 (main)

[dhewg]

Ok, do you get that error mentioned above?
Does it still work if you build just with the first test commit:
source=("git+https://github.com/iXit/wine-nine-standalone.git#f7c0dd65c669e9ca055c227cb6dd6ac6d9440386") ?

[valters-tomsons]

Nope, didn't find anything like that in the log.
Here's the log, just in case: https://gist.github.com/FaithLV/95f31b35733545aaede6631614d16fd4

Will try with first commit in just a sec.

[valters-tomsons]

Nope, doesn't seem to work without second commit.

Log: https://gist.github.com/FaithLV/cbd4711caf5399f09a7d6e7b58efe390

[dhewg]

DRI3Present_FillOffset Coord client area: 0 0
DRI3Present_FillOffset Coord drawable: 1280 0
DRI3Present_FillOffset Offset: -1280 0

The issue is related to the -1280, which matches the x res of your other display. I guess the 1920 display is to the right of the 1280 one? If you switch the right display to the left, does it work then?

[valters-tomsons]

You are correct and changing the monitor order works.

[dhewg]

I just updated the test branch, let's see if this fixes multi monitor setups.
Please test again with #test and post a log!

[valters-tomsons]

Yeah, it seems to be working.

Whoops, here's a log: https://gist.github.com/FaithLV/e1410d838d390f49c5eab17d358cc888

[dhewg]

Hm nope, that patch is made of fail.
Could you please try again the just updated test branch? With log once more (which should we less spammy too) ;)
If that works, it'll land in master!

[valters-tomsons]

Yeah, that seems to work.

Here's the log: https://gist.github.com/FaithLV/06d117425d4b79ee0f521ca624f3e787

[dhewg]

Nice, but log is missing the relevant debug output using WINEDEBUG=d3d9nine :P

[valters-tomsons]

Whoops, sorry. This should be it.

https://gist.github.com/FaithLV/bb044431114aa997f0da8815258f871e

[dhewg]

Perfect, thanks!
Fix is now on master