Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should log unresolved references test should be fixed and no longer skipped #175

Open
nick4598 opened this issue May 3, 2024 · 1 comment · May be fixed by #204
Open

should log unresolved references test should be fixed and no longer skipped #175

nick4598 opened this issue May 3, 2024 · 1 comment · May be fixed by #204
Assignees
@derbynn

Comments

@nick4598
Copy link
Collaborator

nick4598 commented May 3, 2024

After addressing #167, the test should log unresolved references no longer passes. Thats because this test relied on the bug of the repository model being remapped to some other model which isn't valid. This remapping would make it so the repository model could not be found in the target iModel and unresolved references would be reported.

We should fix this test to make sure we still log unresolved references. I'm not entirely sure how to do this.. maybe it could be done by calling IModelExporter.excludeElement on a parent model to create an unresolved reference in the target where the model can't be found.
@nick4598
Copy link
Collaborator Author

nick4598 commented May 3, 2024

This test was broken by this PR: #176

@derbynn derbynn linked a pull request Sep 5, 2024 that will close this issue
Fix 'should log unresolved references' test #204
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derbynn derbynn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 'should log unresolved references' test iTwin/imodel-transformer
2 participants
@nick4598 @derbynn