Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate moving most of native IModelElementContext.nativeContext.cloneElement into JavaScript #10

Open
MichaelBelousov opened this issue Mar 24, 2023 · 2 comments
Assignees
Labels
performance potential performance increase

Comments

@MichaelBelousov
Copy link
Contributor

MichaelBelousov commented Mar 24, 2023

The native components of the transformer (chiefly the IModelElementCloneContext's nativeContext) are potentially somewhat redundant to changes in the exporter's javascript side now.

  • storing mappings (e.g. element remap table) in native code can be slow compared to using a javascript map.
  • harder for our team to maintain.
  • harder for C++ and JS to share core code, C++ should only be used where necessary and not tied to the transformer state as it is now

We should explore moving some more stuff into JavaScript.

@MichaelBelousov MichaelBelousov self-assigned this Mar 24, 2023
@MichaelBelousov MichaelBelousov changed the title Remove some redundant native transformation code. Investigate removing some redundant native transformation code. Mar 24, 2023
@MichaelBelousov
Copy link
Contributor Author

@MichaelBelousov MichaelBelousov changed the title Investigate removing some redundant native transformation code. Investigate moving most of native IModelElementContext.cloneElement into JavaScript Feb 22, 2024
@MichaelBelousov MichaelBelousov changed the title Investigate moving most of native IModelElementContext.cloneElement into JavaScript Investigate moving most of native IModelElementContext.nativeContext.cloneElement into JavaScript Feb 22, 2024
@MichaelBelousov
Copy link
Contributor Author

MichaelBelousov commented Feb 22, 2024

things we need:

@nick4598 nick4598 added the performance potential performance increase label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance potential performance increase
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants