Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2/V3 Theme synchronisation #1730

Closed
raplemie opened this issue Dec 8, 2023 · 1 comment · Fixed by #1731 or #1735
Closed

V2/V3 Theme synchronisation #1730

raplemie opened this issue Dec 8, 2023 · 1 comment · Fixed by #1731 or #1735
Assignees
@mayank99
Labels
enhancement New feature or request

Comments

@raplemie
Copy link
Contributor

raplemie commented Dec 8, 2023

Describe the bug (actual behavior)

V3 ThemeProvider do not sync with V2 ThemeProvider when the theme changes

Expected behavior

Every component that inherit theme should have the same theme than its container.

Reproduction

Link to a minimal repro:
https://stackblitz.com/edit/vitejs-vite-do9c8e?file=src%2FV2.jsx

Steps to reproduce
  1. Application will start in dark mode and everything is synched
  2. Use the "Theme" dropdown and switch to light
  3. V2 section will be in light theme, V3 will stay in dark theme

Additional information
@raplemie raplemie added the bug Something isn't working label Dec 8, 2023
@mayank99 mayank99 self-assigned this Dec 8, 2023
@mayank99 mayank99 added enhancement New feature or request and removed bug Something isn't working labels Dec 8, 2023
@mayank99 mayank99 linked a pull request Dec 8, 2023 that will close this issue
dispatch theme changes via custom events #1731
Merged
@raplemie raplemie mentioned this issue Dec 8, 2023
Open
@mayank99 mayank99 linked a pull request Dec 12, 2023 that will close this issue
use mutation observers to listen to theme changes #1735
Merged
@mayank99
Copy link
Contributor

This is now fixed and released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayank99 mayank99

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@raplemie @mayank99