From 7de79cd07c3163ec86adcab93ddb08ff83d48325 Mon Sep 17 00:00:00 2001 From: Mayank <9084735+mayank99@users.noreply.github.com> Date: Tue, 19 Dec 2023 10:26:24 -0500 Subject: [PATCH] add direct dependency on illustrations (#1744) fixes build errors related to dependency not found, because ErrorPage is present in barrel file and needs to be resolvable even if not used. --- .changeset/gentle-worms-dance.md | 5 +++++ packages/itwinui-react/package.json | 8 +------- 2 files changed, 6 insertions(+), 7 deletions(-) create mode 100644 .changeset/gentle-worms-dance.md diff --git a/.changeset/gentle-worms-dance.md b/.changeset/gentle-worms-dance.md new file mode 100644 index 00000000000..a0340f3de64 --- /dev/null +++ b/.changeset/gentle-worms-dance.md @@ -0,0 +1,5 @@ +--- +'@itwin/itwinui-react': minor +--- + +`@itwin/itwinui-illustrations-react` has been made a direct dependency again, to avoid issues with bundlers attempting to bundle it even if `ErrorPage` is not used anywhere. diff --git a/packages/itwinui-react/package.json b/packages/itwinui-react/package.json index 09334bda0c5..d54472081cb 100644 --- a/packages/itwinui-react/package.json +++ b/packages/itwinui-react/package.json @@ -76,6 +76,7 @@ "dev:styles": "yarn build:styles --watch" }, "dependencies": { + "@itwin/itwinui-illustrations-react": "^2.1.0", "@floating-ui/react": "^0.26.3", "classnames": "^2.3.2", "react-table": "^7.8.0", @@ -84,7 +85,6 @@ }, "devDependencies": { "@itwin/itwinui-css": "^2.1.0", - "@itwin/itwinui-illustrations-react": "^2.1.0", "@itwin/itwinui-variables": "3.0.0", "@swc/cli": "^0.1.62", "@swc/core": "^1.3.68", @@ -114,15 +114,9 @@ "vite": "^4.5.1" }, "peerDependencies": { - "@itwin/itwinui-illustrations-react": "^2.1.0", "react": ">= 17.0.0 < 19.0.0", "react-dom": ">=17.0.0 < 19.0.0" }, - "peerDependenciesMeta": { - "@itwin/itwinui-illustrations-react": { - "optional": true - } - }, "lint-staged": { "*.{tsx,ts,jsx,js}": [ "prettier --write",