Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract integration tests into separate package in monorepo #165

Open
ben-polinsky opened this issue May 3, 2023 · 0 comments
Open

extract integration tests into separate package in monorepo #165

ben-polinsky opened this issue May 3, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@ben-polinsky
Copy link
Collaborator

ben-polinsky commented May 3, 2023 •
edited
Loading

Our integration tests (they're really e2e) currently directly import the code they are testing (in addition to cluttering the package code). We can move them out into their own package, then import the code under test as a user would -- as an external dependency (albeit via rush).

In addition, any test helpers or common configuration should be combined.
@ben-polinsky ben-polinsky added the good first issue Good for newcomers label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ben-polinsky